Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

array_tree_compare is not transitive, sometimes divides by zero #179

Open
charlesreiss opened this issue May 20, 2017 · 0 comments
Open

array_tree_compare is not transitive, sometimes divides by zero #179

charlesreiss opened this issue May 20, 2017 · 0 comments
Labels
bug Something isn't working
Milestone
7.4

Comments

@charlesreiss
Copy link
Contributor

array_tree_compare tries to compare floats using a margin of DBL_EPSILON, but this means that its comparison is not transitive. It also uses division by one of the values being compared to scale this comparison, which sometimes divides by zero.

The division by zero definitely needs to get fixed. Any change to array_tree_compare probably changes the user-visible semantics of MUF dictionaries.
@charlesreiss charlesreiss mentioned this issue Dec 26, 2017
Closed
@tanabi tanabi added the bug Something isn't working label Jul 6, 2021
@tanabi tanabi added this to the 7.4 milestone Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
7.4
Development

No branches or pull requests
2 participants
@charlesreiss @tanabi