[newserv] Joining 11/2000 room on PC with $debug causes segmentation fault

[Matt-Swift]

Describe the bug
When joining an empty 11/2000 room on PCv2 (that seemingly had been up as 0/4 for about 6+ hours), the entire server had a segmentation fault and died.

To reproduce

1. Create 11/2000 room
2. Make it 0/4
3. Join on PC with $debug

Game version(s) (choose one or more of the following):
PC

Server log output

I 127965 2024-04-12 21:27:50 - [Commands] Received from C-55E (Matt) (version=PC_V2 command=10 flag=00)
0000 | 0C 00 10 00 44 00 00 44 0C 01 00 00             |     D  D        
I 127965 2024-04-12 21:27:50 - [Game:10C] Changing section ID to Redria
I 127965 2024-04-12 21:27:50 - [Commands] Sending to C-55E (Matt) (version=PC_V2 command=B0 flag=00)
0000 | 54 00 B0 00 00 00 00 00 00 00 00 00 09 00 43 00 | T             C 
0010 | 35 00 53 00 65 00 63 00 74 00 69 00 6F 00 6E 00 | 5 S e c t i o n 
0020 | 20 00 49 00 44 00 20 00 63 00 68 00 61 00 6E 00 |   I D   c h a n 
0030 | 67 00 65 00 64 00 0A 00 74 00 6F 00 20 00 52 00 | g e d   t o   R 
0040 | 65 00 64 00 72 00 69 00 61 00 20 00 28 00 36 00 | e d r i a   ( 6 
0050 | 29 00 00 00                                     | )               
I 127965 2024-04-12 21:27:50 - [C-55E] Assigned inventory item IDs
[PlayerInventory] Meseta: 999999
[PlayerInventory] 27 items
[PlayerInventory]    0: [+00000004] 00770063 000084B3 80008000 (00610000) 00000000 (MECHGUN +99 (ES))
[PlayerInventory]    1: [+00000004] 00740063 000080B3 80008000 (00610001) 00000000 (SLICER +99 (ES))
[PlayerInventory]    2: [+00000004] 00800063 000084B3 80008000 (00610002) 00000000 (SCYTHE +99 (ES))
[PlayerInventory]    3: [+00000004] 007F0063 000084B3 80008000 (00610003) 00000000 (NEEDLE +99 (ES))
[PlayerInventory]    4: [+00000004] 003C0014 00000105 0437000A (00610004) 00000000 (IMPERIAL PICK +20 5/0/0/55)
[PlayerInventory]    5: [+00000004] 01021400 00000300 04000000 (00610005) 00000000 (Celestial Shield +3DEF +4EVP)
[PlayerInventory]    6: [+0000004C] 01034200 00000000 00000000 (00610006) 00000000 (State/Maintenance)
[PlayerInventory]    7: [+0000004C] 01030300 01000400 00000000 (00610007) 00000000 (God/Power++)
[PlayerInventory]    8: [+0000004C] 01031300 02000000 00000000 (00610008) 00000000 (God/HP)
[PlayerInventory]    9: [+0000004C] 01034100 03000000 00000000 (00610009) 00000000 (God/Battle)
[PlayerInventory]   10: [+0000004C] 02055FD8 F801C611 B4110400 (0061000A) 00C80700 (Varaha LV95 5.04/45.5/45.32/0.04 0% 200IQ PB:M&Y,F,P (red))
[PlayerInventory]   11: [+00000010] 03030000 00080000 00000000 (0061000B) 00000000 (Sol Atomizer x8)
[PlayerInventory]   12: [+0000004C] 0044005A 00000119 04230205 (0061000C) 00000000 (RED HANDGUN +90 25/5/0/35)
[PlayerInventory]   13: [+0000004C] 01010F00 00040000 00000000 (0061000D) 00000000 (General Armor (4 slots))
[PlayerInventory]   14: [+00000010] 03000200 000A0000 00000000 (0061000E) 00000000 (Trimate x10)
[PlayerInventory]   15: [+00000010] 03040000 00030000 00000000 (0061000F) 00000000 (Moon Atomizer x3)
[PlayerInventory]   16: [+00000010] 03000100 00030000 00000000 (00610010) 00000000 (Dimate x3)
[PlayerInventory]   17: [+00000010] 030B0400 00000000 00000000 (00610011) 00000000 (TP Material)
[PlayerInventory]   18: [+00000010] 030B0600 00000000 00000000 (00610012) 00000000 (Hit Material)
[PlayerInventory]   19: [+00000004] 01030B00 00000100 00000000 (00610013) 00000000 (God/Arm+)
[PlayerInventory]   20: [+00000010] 030B0100 00000000 00000000 (00610014) 00000000 (Mind Material)
[PlayerInventory]   21: [+00000010] 03070000 00020000 00000000 (00610015) 00000000 (Telepipe x2)
[PlayerInventory]   22: [+00000010] 030B0700 00000000 00000000 (00610016) 00000000 (Luck Material)
[PlayerInventory]   23: [+00000004] 01033E00 00000000 00000000 (00610017) 00000000 (God/Technique)
[PlayerInventory]   24: [+00000010] 030E0D00 00000000 00000000 (00610018) 00000000 (Weapons Leather Badge)
[PlayerInventory]   25: [+00000010] 030B0100 00000000 00000000 (00610019) 00000000 (Mind Material)
[PlayerInventory]   26: [+00000010] 030E0D00 00000000 00000000 (0061001A) 00000000 (Weapons Leather Badge)
I 127965 2024-04-12 21:27:50 - [C-55E] Bank is empty
I 127965 2024-04-12 21:27:50 - [Commands] Sending to C-55E (Matt) (version=PC_V2 command=64 flag=01)
0000 | 50 01 64 01 00 00 00 00 00 00 00 00 00 00 00 00 | P d             
0010 | 03 00 00 00 00 00 00 00 02 00 00 00 00 00 00 00 |                 
0020 | 00 00 00 00 01 00 00 00 00 00 00 00 02 00 00 00 |                 
0030 | 01 00 00 00 01 00 00 00 01 00 00 00 01 00 00 00 |                 
0040 | 01 00 00 00 01 00 00 00 01 00 00 00 00 00 00 00 |                 
0050 | 01 00 00 00 02 00 00 00 00 00 00 00 00 00 00 00 |                 
0060 | 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |                 
0070 | 00 00 00 00 00 00 00 00 00 00 00 00 01 00 00 00 |                 
0080 | 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |                 
0090 | 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |                 
00A0 | 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |                 
00B0 | 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |                 
00C0 | 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |                 
00D0 | 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |                 
00E0 | 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |                 
00F0 | 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |                 
0100 | 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |                 
0110 | 00 00 00 00 00 00 01 00 6C D3 4A BE 7F 00 00 01 |         l J     
0120 | 03 00 00 00 4D 00 61 00 74 00 74 00 00 00 00 00 |     M a t t     
0130 | 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |                 
0140 | 00 00 00 00 03 03 01 00 00 04 06 00 6B 04 AF DE |             k   
I 127965 2024-04-12 21:27:50 - [C-55E] Creating game join command queue
I 127965 2024-04-12 21:27:50 - [Commands] Sending to C-55E (Matt) (version=PC_V2 command=1D flag=00)
0000 | 04 00 1D 00                                     |                 
I 127965 2024-04-12 21:27:50 - [Commands] Received from C-55E (Matt) (version=PC_V2 command=1D flag=00)
0000 | 04 00 1D 00                                     |                 
I 127965 2024-04-12 21:27:50 - [C-55E] Sending 0 queued command(s)
I 127965 2024-04-12 21:27:50 - [Game:10C] Sending next item IDs to client: 00010000 00210000 00410000 0061001B
I 127965 2024-04-12 21:27:50 - [Commands] Sending to C-55E (Matt) (version=PC_V2 command=6D flag=03)
0000 | 4C 00 6D 03 6D 00 00 00 48 00 00 00 8C 00 00 00 | L m m   H       
0010 | 35 00 00 00 A9 00 EE FF 00 0C 01 0D 00 21 11 00 | 5            !  
0020 | 41 AF 00 1B 00 61 15 00 81 1D 00 A1 4A 21 00 C1 | A    a      J!  
0030 | 25 00 E1 0D 01 10 00 21 31 00 05 41 35 00 61 10 | %      !1  A5 a 
0040 | 01 40 0F 52 0F 64 0F 29 00 00 00 00             |  @ R d )        
./newserv.sh: line 5: 127965 Segmentation fault      ./newserv
I 158018 2024-04-12 21:27:51 - [Config] newserv 40d5c6ee+ compiled at 2024-04-08 06:36:31

[fuzziqersoftware]

I wasn't able to reproduce this. It has likely been fixed at some point since this issue was submitted, since I've recently reworked how the server sends state in persistent games. Please reopen if you see any issue like this again.