Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to complete in one Tab #39

Closed
KleMiX opened this issue May 2, 2014 · 3 comments
Closed

Option to complete in one Tab #39

KleMiX opened this issue May 2, 2014 · 3 comments

Comments

@KleMiX
Copy link

KleMiX commented May 2, 2014

In previous version I was pressing Tab once to complete whole expression. Now I have to press Tab many times to complete some types and it loses selected type after Tab and selects another which is annoying. Example:
typing "buil", getting suggestions BuildingData and buildingData, selecting second and pressing tab will select BuildingData again and stop after word Building.

It would be really great if you could add some checkbox in options so we can complete expressions with single Tab press.

@slazyk
Copy link
Member

slazyk commented May 2, 2014

Ok, I would this is basically two separate issues:

  1. The completion is not chosen after pressing Tab
    Why won't you use Enter which accepts the current completion instead? It always worked like this in Xcode... Tab inserts a prefix, Enter inserts the whole thing.
  2. The selection is not being kept after pressing Tab
    This might be a genuine issue for some users. It might indeed be annoying. But still, if you are inserting just a prefix (which you can see underlined) and not the completion itself, why would you want it to stay on this particular item? If you were interested in this particular item alone you would press Enter, right?

Let me know your thoughts.

@slazyk
Copy link
Member

slazyk commented May 2, 2014

I would say that 2. point from my previous comment should be fixed.

I've checked, and indeed Xcode's default behaviour is to keep the selection when you Tab or just type the letters. The selection jumps to best match when what you type doesn't match current selection or when you backspace. With fuzzy matches it's a little more complicated than that, but it should remain consistent with Xcode's default.

As for 1. my question still remains, @KleMiX why would you want to accept current completion with Tab when you can with Enter? If there is an option to accept with Tab there should probably also be one to accept with Space, ...

@KleMiX
Copy link
Author

KleMiX commented May 5, 2014

  1. Didn't know Enter is doing that, that's a good tip. I come from Visual Studio world where Tab is working as Enter in Xcode that's why I really liked this behaviour your plugin did before. This resolves my issue.
  2. Your thoughts on this one are also correct. Still could be a minor issue.

@KleMiX KleMiX closed this as completed May 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants