Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Info.plist template not used #28

Closed
bdemers opened this issue Apr 15, 2020 · 2 comments
Closed

Custom Info.plist template not used #28

bdemers opened this issue Apr 15, 2020 · 2 comments

Comments

@bdemers
Copy link

bdemers commented Apr 15, 2020

I created a <project-root>/assets/macosx/Info.plist.vtl file (based on the default velocity template), and it's not getting picked up. Is this expected?

I'm probably reading the code wrong, but it looks like the velocity templates are just pulled from the plugin classpath.

@fvarrui
Copy link
Owner

fvarrui commented Apr 15, 2020

Hi again @bdemers,

I created a /assets/macosx/Info.plist.vtl file (based on the default velocity template), and it's not getting picked up. Is this expected?

Sorry! There was an error on README doc. Assets folder for Mac OS X has to be called mac, so you have to use in your case:
<project-root>/assets/mac/Info.plist.vtl .

I'm probably reading the code wrong, but it looks like the velocity templates are just pulled from the plugin classpath.

Velocity templates were getting picked up from plugin classpath because it could't find templates in assets\mac folder.

You were doing right! Documentation was wrong, sorry.

Thanks for using JavaPackager and for your feedback!

@fvarrui fvarrui closed this as completed Apr 16, 2020
@bdemers
Copy link
Author

bdemers commented Apr 17, 2020

That was it! thanks for the quick update @fvarrui!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants