Change breaks with the non-unicode InnoSetup 5.x version... it cant read the iss file.

[fvarrui]

          FYI: This change breaks with the non-unicode InnoSetup 5.x version... it cant read the iss file. 

This IS version is old, but this could be added to the documentation. (use 6.x or 5.x Unicode)

Originally posted by @commi in #271 (comment)

[lhDream]

We can increase the configuration and set not to write BOM. 👀

[commi]

That would also work... but since the iss scripts are written in UTF-8, this can create garbled strings in IS 5. So maybe the BOM is a nice 'safeguard' against this:)
In any case you could add to https://github.com/fvarrui/JavaPackager/blob/master/docs/windows-tools-guide.md that IS 5 non-unicode is not supported, because there is just no way to support both and having umlauts in the app name for instance.

Edit: made #299

[fvarrui]

We can increase the configuration and set not to write BOM. 👀

I was thinking of finding out the version of Inno Setup using the command iscc /? or something like that, and then decide whether to add BOM to the .iss files or not ... but your approach is much simpler and better 😅

[fvarrui]

winConfig.iss.bom=true|false?

[fvarrui]

I think a system that allows adding/deleting the BOM in the files generated from the Velocity templates would be more flexible, allowing you to select the template to which it's applied.

I mean:

<templates>
    <template>
        <name>iss.vtl</name>
        <bom>true|false</name>
        [here we can add new options for future features related to templates]
    </template>
</templates>

[fvarrui]

Work in progress in branch issue-297

[fvarrui]

Just published 1.7.3-20230701.111610-13 snapshot version.

How to disable UTF-8 with BOM for iss files:

<templates>
    <template>
        <name>windows/iss.vtl</name>
        <bom>false</bom>
    </template>
</templates>

UTF-8 with BOM is enabled by default just as it was before.

[fvarrui]

Can we release this feature in 1.7.4?

[commi]

I see no reason why not:)

[fvarrui]

Branch issue-297 merged into devel, ready to be released in v1.7.4

[fvarrui]

1.7.4 released to Maven Central