Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update jsign to 4.1+ #351

Closed
1 of 3 tasks
commi opened this issue Aug 10, 2023 · 4 comments
Closed
1 of 3 tasks

Update jsign to 4.1+ #351

commi opened this issue Aug 10, 2023 · 4 comments
Labels
enhancement New feature or request fixed Issue fixed and release pending merged Changes merged into devel branch

Comments

@commi
Copy link
Contributor

commi commented Aug 10, 2023

I'm submitting a…

  • bug report
  • feature request
  • other

We'd like to use jsign with SSL.com's eSigner, and jsign supports this from version 4.1 on (https://github.com/ebourg/jsign/releases/tag/4.1). I saw that the relevant params are already passed to jsign unaltered (except for storetype=PKCS11).

What is the motivation / use case for changing the behavior?

MS Authenticode requires USB-Tokens for Key-Storage from now on. An alternative is string the Key at a external Service that allows access to the signing process via API. SSL.com offers an API that jsign supports.

Other information (e.g. related issues, suggestions how to fix, links for us to have context)

The API of jsign might have changed since the versin curently used... if this is more than a simple change in the pom.xml then i'll work on a pull request.
@fvarrui
Copy link
Owner

fvarrui commented Aug 11, 2023

Hi @commi!
I've just upgraded jsign to 5.0 and publish a snapshort version: 1.7.4-20230811.145854-1.
Please, try it and give me some feedback.
Thanks!!

@fvarrui fvarrui added enhancement New feature or request feedback Waiting for feedback labels Aug 11, 2023
@commi
Copy link
Contributor Author

commi commented Aug 11, 2023

Tested and works!

@fvarrui fvarrui added fixed Issue fixed and release pending and removed feedback Waiting for feedback labels Aug 16, 2023
@fvarrui
Copy link
Owner

fvarrui commented Aug 22, 2023

Branch issue-351 merged into devel, ready to me released in v1.7.4

@fvarrui fvarrui added the merged Changes merged into devel branch label Aug 22, 2023
@fvarrui
Copy link
Owner

fvarrui commented Aug 30, 2023

1.7.4 released to Maven Central

@fvarrui fvarrui closed this as completed Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request fixed Issue fixed and release pending merged Changes merged into devel branch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@commi @fvarrui