Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

count is not updated when a spawned process crashes #15

Closed
asafyish opened this issue Feb 14, 2016 · 4 comments
Closed

count is not updated when a spawned process crashes #15

asafyish opened this issue Feb 14, 2016 · 4 comments

Comments

@asafyish
Copy link
Contributor

Hi,

When using electron-screenshot-service, sometimes the electron process crashes for unknown reasons, that's not a problem on it's own, but electron-screenshot-service doesn't decrease the count, so the next screenshot call fails.

Will you accept a PR for that ? it will move startElectron into createBrowser because it's needs acces to count.
@asafyish
Copy link
Contributor Author

Also, it seems the commands are still sent to the dead process, and because it's dead - you never get a reply.

@FWeinb
Copy link
Owner

FWeinb commented Feb 20, 2016

I would really like a PR for better process management. I don't have much time at hand currently.

@asafyish
Copy link
Contributor Author

Attached #16

@FWeinb
Copy link
Owner

FWeinb commented Feb 24, 2016

👍

@FWeinb FWeinb closed this as completed Feb 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FWeinb @asafyish