-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compiling error on M1 Macbook pro #50
Comments
Hi @usccolumbia, I am having the same issue. Could you find a solution? Thank you. |
I have a branch where I started working on a fix for M1 macs. I do t have a mac to debug on. I’d really love some help fixing this! Happy to help pair program on this. |
I think that the issue could be the incompatibility of the external libraries Maybe a solution could be to install |
I'd like to explore getting rid of Geogram as a dependency. The latest version of embree does work on M1/M2 macs as discussed here in #42 I think the only functions using Geogram currently are the ones in One option is to disable it only on Mac for now. |
Thank you, I have updated Updating |
Thanks @maurock for looking into this! How does it break fast_winding_numbers? Is it a compiler error or does it not work at runtime? Could you post the error and I'll try and fix it. If you also send a PR I can see if I can repro the fast_winding_number problem locally (assuming it also breaks on Linux). |
@maurock I created a branch which (1) updates embree, and (2) updates libIGL. I also fixed the Link to the PR with the changes is here: #54 |
Hi @fwilliams, thanks. I have added the checks for geogram and lloyd.cpp, but it still fails when it reaches
|
In addition to my previous comment: by replacing
|
Thanks @maurock ! Can you try the latest commit on PR #54 now? I patched this file with the fix from here libigl/libigl@1db662b |
It compiles with no errors! But I had to place a few checks for geogram and lloyd.cpp, so python returns this error when I import the package:
|
Ah yeah that’s because lloyd_2d is implemented using geogram 🙂 this import needs to be fenced off on macos |
Hi @fwilliams, I have slightly edited the I am going to test it and add it to my workflow right away :) Should I make a merge request so that you can see the changes I made? |
🎉 🎉 🎉 great! I am going to merge #54 which does most of what you need. Can you create a PR with your changes on top of the updated main branch? We can hopefully get this merged and I'll cut a new release with M1 mac support! |
@maurock Okay everything is merged, you can rebase your changes and create a PR! |
This is fixed! I'll release a new version soon. Meanwhile, source builds should work on M1 macs and ARM processors in general. |
when pip install point_cloud_utils
got this error:
CMake Error: The source directory "/private/var/folders/_1/z9htdvys25dbgnl4nfxmvhf80000gn/T/pip-install-ihjh_3ei/point-cloud-utils_55486fa531a24a6886398db7d72c948d" does not appear to contain CMakeLists.txt.
The text was updated successfully, but these errors were encountered: