Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist properties when preview window is closed #921

Closed
valtism opened this issue Aug 12, 2022 · 4 comments
Closed

Persist properties when preview window is closed #921

valtism opened this issue Aug 12, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@valtism
Copy link

valtism commented Aug 12, 2022

Is your feature request related to a problem? Please describe.
It is annoying to have to keep inputting the same values when the preview window closes for various reasons.

Describe the solution you'd like
I would like to be able to close the preview window, and re-open it and have the same input fields I had when I had closed the window, or as close to what I had as possible if some props have changed.

@valtism valtism added the enhancement New feature or request label Aug 12, 2022
@valtism
Copy link
Author

valtism commented Aug 12, 2022

Unsure of how feasible this would be as PreviewJS would have to persist data, and I don't know if it does that already.

@fwouts
Copy link
Owner

fwouts commented Aug 12, 2022

How long would you imagine the props being persisted for, ideally? If you restarted your IDE or your computer or came back a day or two later would you prefer them to still be there?

@valtism
Copy link
Author

valtism commented Aug 12, 2022

Yes, Ideally they would persist as long as possible. It's super easy to clear them all so stale inputs wouldn't be much of a problem I think

@fwouts
Copy link
Owner

fwouts commented Apr 28, 2023

This was implemented in v1.22 with the "New preview" button :)

@fwouts fwouts closed this as completed Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants