Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small bug in getApiSignature (with fix) #6

Closed
etx opened this issue Apr 21, 2011 · 1 comment
Closed

small bug in getApiSignature (with fix) #6

etx opened this issue Apr 21, 2011 · 1 comment

Comments

@etx
Copy link

etx commented Apr 21, 2011

Hey!

Thanks for the very useful code, it's great. I found a small bug.

In getApiSignature at line 832 you're using for(var index in keys). This was causing the functions in my array prototype to be added to the string that is used to build the MD5 hash. Switching it to this (below) fixed it right up. I'd commit a patch or something but I'm no good at git.

for(var i=0; i<keys.length; i++){
var key = keys[i];
string += key + params[key];
}

@fxb
Copy link
Owner

fxb commented Jun 23, 2015

Fixed.

@fxb fxb closed this as completed Jun 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants