M - ; comments not closing

[seanareed]

I recently upgraded web-mode.

I use it with PHP, and love it.

Since then, the M - ; shortcut for comments doesn't close those comments in a PHP block within web-mode.

Is it possible that this is due to a change in web-mode?

I'm attaching images of what it used to do and what it does now.

Thanks,
Sean

[fxbois]

@seanareed I do not plan to provide this kind of comments ... perhaps someone could provide a function (ask on stackoverflow)

[seanareed]

Ok. Thanks. I may take a stab at it myself. Cheers, S

[itkach]

It also does this now when editing javascript too. If I set web-mode-set-content-type to jsx in js buffer then it closes the comment properly.

[seanareed]

Thanks!
That works for me too!

Is there a way to add something to the init file that automatically sets this on opening php files?

[itkach]

Setting wrong content type on a buffer is a useful workaround, but this is still broken, inserts /*. Should this issue really be closed?
Ideally, for javascript it should be // (these can be nested while multi-line comments can't be).

[fxbois]

as I wrote in my first comment, I do not plan to work on this. Perhaps someone could write a minor mode to handle this

[jasondf]

Well, I got the same issue, and try to do a stab myself, lucky me it works. Here is the screenshot:

Now M-; works in PHP file and php block in HTML file. Although I don't know if there is any side effects.

[seanareed]

I looked at the diffs from the commit to web-mode.el on 15-Sep-2015 ('jsx commenting'), which is when I noticed the change in behavior.

The original code had a (not ) that is missing in the new code.

I don't know if this was intentional or an oversight.

However, adding that (not ) back in returns the proper closing behavior that was present before.

Changing line 8302 in the added code (green) to (not (string= alt "/*"))) remedies the issue for me.

-S

[seanareed]

(...however, I have to evaluate the web-mode.el buffer for it to take effect.)

[seanareed]

(...ah, yes... the .el library must be byte-compiled first... there is an .elc version.)

[jasondf]

@seanareed it works for me, thanks a lot.