Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The mimetype should be an Id, rather than a String. #18

Closed
Yoric opened this issue Mar 7, 2016 · 2 comments
Closed

The mimetype should be an Id, rather than a String. #18

Yoric opened this issue Mar 7, 2016 · 2 comments
Labels
Help wanted Quality: Performance Quality: Safety Skill: Rust

Comments

@Yoric
Copy link
Collaborator

Yoric commented Mar 7, 2016

There will probably be very few distinct mimetypes in the system, and we don't want to confuse a mimetype string with something else.

So, in values.rs, in the definition of Binary, we should use Id<MimetypeId> instead of String for the mimetype. This way, once issue #11 has landed, we'll benefit automatically from string caching.
@hfiguiere
Copy link
Contributor

According to commit cd4bf66 this is already done. @Yoric ?

@Yoric
Copy link
Collaborator Author

Yoric commented Mar 15, 2016

Right, thanks,

@Yoric Yoric closed this as completed Mar 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Help wanted Quality: Performance Quality: Safety Skill: Rust
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Yoric @hfiguiere