Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added maven plugin for proper jitpack build pipeline #1

Merged
merged 1 commit into from May 1, 2022

Conversation

lyze237
Copy link
Contributor

@lyze237 lyze237 commented May 1, 2022

Hey!

This PR cleans up your git repo a bit and also adds proper maven tasks so jitpack works properly.

Mainly:

  • Added a gitignore file for all the useless files
  • Deleted everything committed which was in the .gitignore file (.gradle, eclipse project files, ...)
  • Deleted the bin folder, doesn't seem useful
  • Updated gradle version
  • And updated your gradle file a bit and added a publishing gradle file which defines a couple meta data for the repo

@bonenaut7
Copy link
Owner

Thanks for help!!

@bonenaut7 bonenaut7 merged commit f86102b into bonenaut7:main May 1, 2022
Copy link

@tommyettinger tommyettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, it's already merged... 😅

@@ -2,4 +2,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-4.3-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-7.3.3-bin.zip

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this could be updated to 7.4.2 today, I'd rather just update to 7.5 when it becomes available (since using 7.3.x or higher gets us Java 17 compatibility, but we would need the unreleased Gradle 7.5 to support Java 18).

@@ -0,0 +1,18 @@
publishing {
publications {
gdxTinyVG(MavenPublication) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name should probably not be gdxTinyVG.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hate that you need to define a name there, always forget to change it :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants