Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusion about main.lua #1

Closed
sunshineatnoon opened this issue Sep 6, 2016 · 2 comments
Closed

Confusion about main.lua #1

sunshineatnoon opened this issue Sep 6, 2016 · 2 comments

Comments

@sunshineatnoon
Copy link

Hi, thanks for opensource this project.
I have some confusions about line 283 in main.lua:
local df_dg = netD:updateGradInput(input_img, df_do)

When you do backpropagation wrt to D, shouldn't you backpropagate to fake image? It seems that you backpropagate to input image here.

@fxia22
Copy link
Owner

fxia22 commented Nov 26, 2016

Hi, @sunshineatnoon thank you for your feedback. I was busy on other projects so didn't have time to fix it until now. Now it's fixed, I have tested and it works well on LOOKBOOK dataset (will post results in a day or two). Let's me know if there are any further issues.

Cheers,
Fei

@sunshineatnoon
Copy link
Author

Cool, Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants