Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't apply changes permanently #112

Closed
roridev opened this issue Oct 10, 2022 · 4 comments
Closed

Can't apply changes permanently #112

roridev opened this issue Oct 10, 2022 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@roridev
Copy link

roridev commented Oct 10, 2022

Describe the bug
carpet-fixes can't load the configuration file nor save to it, making applying changes permanently impossible.

To Reproduce
There are two ways to reproduce this behaviour, since this bug report is a combination of two possible paths to achieve it.

Steps to reproduce the behavior (via configuration file):

  1. create a configuration file on world/carpet-fixes.conf
  2. add any fix to it
  3. open the server
  4. type /carpet-fixes
  5. see that the mod didn't load anything

Steps to reproduce the behavior (via in-game commands):

  1. set any fix
  2. once the mod asks you to set it permanently, click on the message and press enter
  3. see the "an unexpected error has occured"

Expected behavior
carpet-fixes loads and saves to the per-world permanent settings.

Screenshots
image

Minecraft Version:

  • 1.19.2
    Carpet-Fixes Version:
  • v1.12.0
    Carpet Version:
  • v1.4.83+v220727

Additional context
carpet-fixes didn't seem to load the per-world configuration file (which seemed to be located at world/carpet-fixes.conf) on my local test server, which prompted me to research if i could set those configurations permanently by hand, which would still be a bother but make carpet-fixes a part of the server-side modpack.

while trying to set the fixes permanently, the game returned that "An unexpected error occured trying to execute that command", and upon closer inspection that NPE (or most likely, a mixin error, cause there would be no way that this.server would be null while the mod has loaded).

"net.minecraft.server.MinecraftServer.method_27050(net.minecraft.class_5218)" seems to be the cause of that issue. i currently don't have any tooling configured but could help finding the cause of that bug once i have that setup.

@roridev roridev added the bug Something isn't working label Oct 10, 2022
@roridev
Copy link
Author

roridev commented Oct 10, 2022

I can confirm that this bug happens on clean quilt and fabric servers with only carpet and carpet-extras
image
image

@FxMorin
Copy link
Owner

FxMorin commented Oct 10, 2022

@adryd325

@adryd325
Copy link
Contributor

will get to fixing this shortly

@FxMorin
Copy link
Owner

FxMorin commented Oct 12, 2022

Fixed in latest release

@FxMorin FxMorin closed this as completed Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants