Bug fix in the read/write/delete samples with LocalStack #2067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
April 7, 2023 16:22
…k version Signed-off-by: Arad Halevy <arad.halevy@ibm.com>
…y/fybrik into add-LocalStack-version
…k version across fybrik Signed-off-by: Arad Halevy <arad.halevy@ibm.com>
…tall Signed-off-by: Arad Halevy <arad.halevy@ibm.com>
Signed-off-by: Arad Halevy <arad.halevy@ibm.com>
Signed-off-by: Arad Halevy <arad.halevy@ibm.com>
roytman
reviewed
Apr 9, 2023
| @@ -25,6 +27,7 @@ if [[ "$FYBRIK_VERSION" == "" ]]; then | |||
| # Get Fybrik lateset realease from github | |||
| FYBRIK_VERSION=$(git -c 'versionsort.suffix=-' ls-remote --tags --sort='v:refname' https://github.com/fybrik/fybrik.git | tail --lines=1 | cut --delimiter='/' --fields=3) | |||
| fi | |||
| FYBRIK_BRANCH_OMD="$FYBRIK_VERSION" | |||
There was a problem hiding this comment.
why do you need a separate FYBRIK_BRANCH_OMD env variable?
There was a problem hiding this comment.
it is as it is installed in the QuickStart, it is used for the OpenMetaData script, but it needs to be FYBRIK_BRANCH and exported for it to work for that.
I changed it accordingly.
roytman
reviewed
Apr 9, 2023
Signed-off-by: Arad Halevy <arad.halevy@ibm.com>
aradhalevy
force-pushed
the
add-LocalStack-version
branch
from
50aa9d5
to
ac3d6c7
Compare
roytman
approved these changes
Apr 9, 2023
|
Hello @aradhalevy @roytman as of version v1.3.2, this fix is missing in OneClickDemo, see: the same issue appears in the step-by-step guides page here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added control over the version of LocalStack that is installed (not just taking the latest) as part of the samples flow.
This way, when LocalStack updates it won't break like happened #2052.
closes #2052