Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate theme.FyneLogo() from theme package #3296

Closed
2 tasks done
Jacalz opened this issue Sep 30, 2022 · 1 comment
Closed
2 tasks done

Deprecate theme.FyneLogo() from theme package #3296

Jacalz opened this issue Sep 30, 2022 · 1 comment
Assignees

Comments

@Jacalz
Copy link
Member

Jacalz commented Sep 30, 2022

Checklist

  • I have searched the issue tracker for open issues that relate to the same feature, before opening a new one.
  • This issue only relates to a single feature. I will open new issues for any other features.

Is your feature request related to a problem?

We should try to clean up the theme package for icons that we don't need. This Fyne logo was used back in the day but right now it is basically only used in fyne_demo, one single place in the driver as well as in a bunch of tests.

Is it possible to construct a solution with the existing API?

We should remove it, yes.

Describe the solution you'd like to see.

Deprecate the icon and move the tests to using something else. We can bundle the icon in fyne_demo and make sure that the internal driver don't set the logo when no other is provided. It might be better for applications to not have any when the developer does not select one. This makes it more clear that they should add their own icon.

@Jacalz Jacalz added the information-needed Further information is requested label Sep 30, 2022
@Jacalz Jacalz self-assigned this Oct 3, 2022
@Jacalz Jacalz added this to the Dalwhinnie (early 2023) milestone Nov 12, 2022
@Jacalz
Copy link
Member Author

Jacalz commented Apr 2, 2023

This is now solved on develop.

@Jacalz Jacalz closed this as completed Apr 2, 2023
@Jacalz Jacalz removed the information-needed Further information is requested label Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant