Bower file and callback fix #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When cancel is selected, there is no corresponding input element, which means that this is set to null in the callback function. The "link" parameter to the callback function is set to the first 'a' child of null, which translates to the first link on the page. Fix the link parameter, by setting a rater-cancel-# (where # is the rater serial number) class on the cancel element, so that we can identify the element later in the select function.
fyneworks
added a commit
that referenced
this pull request
Aug 6, 2014
Bower file and callback fix (thanks @ksmadsen)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
We've recently discovered an issue when using the callback function on the "cancel" element, where it was impossible to determine which rating had changed.
This pull request fixes this issue, and also includes a bower.json file, which we use in our setup. The last patch in this pull request is a simple indentation fix.