Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute recurrent contribution from spikes #9

Closed
smonsays opened this issue Apr 30, 2021 · 1 comment
Closed

Compute recurrent contribution from spikes #9

smonsays opened this issue Apr 30, 2021 · 1 comment

Comments

@smonsays
Copy link

smonsays commented Apr 30, 2021

Hey Friedemann,

thank you for the very comprehensive tutorial! I have a question on the way the recurrence is computed in tutorial 4. If I understand the equation for the dynamics of the current correctly, the recurrence should be computed with the spiking neuron state:

mthr = mem-1.0
out = spike_fn(mthr)
h1 = h1_from_input[:,t] + torch.einsum("ab,bc->ac", (out, v1))

Instead in tutorial 4, a separate hidden state is kept, that ignores the spike function:

h1 = h1_from_input[:,t] + torch.einsum("ab,bc->ac", (h1, v1))

Is this done deliberately? Judging from simulating a few epochs, the two versions seem to perform similarly.

Thank you,

Simon

@fzenke
Copy link
Owner

fzenke commented Apr 30, 2021

Thanks for pointing this out. It looks like a bug.

@fzenke fzenke closed this as completed in e5fbe3e Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants