Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zodiac Type #102

Open
must-be-rohit opened this issue Jan 13, 2024 · 5 comments
Open

Zodiac Type #102

must-be-rohit opened this issue Jan 13, 2024 · 5 comments

Comments

@must-be-rohit
Copy link

Hello,
What is the way to convert the zodiac calculations from Tropic to Sidereal
print(Kundali.zodiac_type)
Tropic

@must-be-rohit
Copy link
Author

must-be-rohit commented Jan 13, 2024

After studying the code got the parameter zodiac_type="Sidereal" under AstrologicalSubject() that can be used to change the calculations. Even after changing the type, the planet positions do not match with the positions provided by astrology software.
How to use this mode from the main swisseph
swe.set_sid_mode(swe.SIDM_LAHIRI)

@must-be-rohit
Copy link
Author

While studying the code further I got to the module astrological_subject and the SIDM flag is not set to LAHIRI due to which certain calculations for sidereal are incorrect.

def _planets_degrees_lister(self):
"""Sidereal or tropic mode."""
self._iflag = swe.FLG_SWIEPH + swe.FLG_SPEED

    if self.zodiac_type == "Sidereal":
        self._iflag += swe.FLG_SIDEREAL
        **#mode = "SIDM_FAGAN_BRADLEY"
        mode = "SIDM_LAHIRI"**
        swe.set_sid_mode(getattr(swe, mode))

Possible to rollout a fix for this?

@g-battaglia
Copy link
Owner

Hi, thank you for pointing out that problem, if you submit a pull request with the fix I'll be glad to integrate your code!

@must-be-rohit
Copy link
Author

I just created the pull request with the update, if you can verify and merge

@g-battaglia
Copy link
Owner

I have to take a better look at it, this pull request makes "SIDM_LAHIRI" the default, the best option would be to create another kwarg to the AstrologicalSubject class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants