Clean up & Update gradle config #15
Conversation
|
Figured out why it was not compiling |
| minSdkVersion(21) | ||
| targetSdkVersion(29) | ||
| minSdk = 21 | ||
| targetSdk = 31 |
There was a problem hiding this comment.
Hey, sorry for taking this long to answer, either GitHub didn't notify me or I missed the notification :(
Anyway, thanks for the contribution! My only question is about the targetSdk. Any reason for bumping it from 29 to 31? It's been a looooong time since I developed for Android so I don't remember what it'll affect in the end. If it doesn't affect much, I don't see why not.
[Edit for clarification: I just want the library to be compatible with the most devices possible, since it doesn't do much that isn't supported from Android 1.0]
There was a problem hiding this comment.
31 is for android 12
32 is for android 12L
Its best to target the latest releases at all times, and always maintain the latest min version.
|
Any news on this PR? I also can not build the project |
| @@ -7,10 +7,14 @@ dependencyResolutionManagement { | |||
| } | |||
|
|
|||
| pluginManagement { | |||
| repositories { | |||
| google() | |||
There was a problem hiding this comment.
Also needs mavenCentral() here, otherwise fails with
Could not GET 'https://jcenter.bintray.com/....'. Received status code 502 from server: Bad Gateway
There was a problem hiding this comment.
Heya!
Could you try with the version up on main right now?
I've addressed these and some other changes there some time ago. For example, here's mavenCentral() on settings.gradle.kts: https://github.com/g0dkar/qrcode-kotlin/blob/main/settings.gradle.kts#L3-L5
If it still doesn't work, please let me know! :D
There was a problem hiding this comment.
It is strange, how does it work on your side?
For me it fails on Plugin [id: 'com.android.library', version: '7.2.1', artifact: 'com.android.tools.build:gradle:7.2.1'] was not found in any of the following sources too.
Also the mavenCentral you mentioned is for the project dependencies, not for plugins
There was a problem hiding this comment.
Ah, I see!
Everything is working here 🤔
I think I know why it is working here tho: some shenanigans I have to have in place for my work. Let me comment those and try again!
Thanks for bringing this into light! <3
There was a problem hiding this comment.
Okay, it WAS the stuff I had in place for work 🤦
I'm committing the fixes right now! Thanks again for reporting on this!
There was a problem hiding this comment.
Okay, I just sent some fixes for this. Could you try again, please? 🙇
|
So? |
|
Hey everyone, sorry for taking so long to take care of this one. Life got quite hectic in the past 6 months or so. Could you confirm you can build the project now @Doomsdayrs and @shalva97? Thanks! |
A minor clean up to get things working properly, as sync seemed to have failed otherwise.
Do ignore the name of the branch
Please do note that the project fails to build the JVM target for some reason