Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nav menu 的 class 問題 #62

Closed
carlcarl opened this issue Dec 30, 2013 · 4 comments · Fixed by #67
Closed

nav menu 的 class 問題 #62

carlcarl opened this issue Dec 30, 2013 · 4 comments · Fixed by #67
Labels

Comments

@carlcarl
Copy link
Contributor

class 其中的 .active 似乎有點怪怪的,直覺應該是點到哪一項就 assign active class 到對應的 item 上才對(?),另外 .active 也有重複 assign 的部分。

@ipaaa
Copy link
Member

ipaaa commented Dec 31, 2013

我抄的是這頁的 "pointing":
http://semantic-ui.com/modules/dropdown.html
沒有顯示會換,只有menu,沒有dropdown則會顯示:
http://semantic-ui.com/collections/menu.html
是 semantic ui class 的問題嗎?要怎麼修?

重複的 active 要砍掉+1

@carlcarl
Copy link
Contributor Author

嗯...先把多餘的 active 拿掉了。
.active assign 的部分看了一下,官方網站看起來有另外 load 一個 menu.js 來切換 .active 狀態,不過也許也不需要加進來,因為 g0v menu 上的幾乎都是 dropdown,可能也不太適用(?)。

@carlcarl
Copy link
Contributor Author

@clkao
Copy link
Member

clkao commented Dec 31, 2013

應該是 extend layout 時要給目前的 toplevel menu class, 好讓 layout.jade 指定 active

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants