Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete pyg4ometry docker image #3

Open
stewartboogert opened this issue Aug 5, 2023 · 4 comments
Open

Complete pyg4ometry docker image #3

stewartboogert opened this issue Aug 5, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@stewartboogert
Copy link
Member

We should have a complete docker image to run pyg4ometry (opposed to the build environment for testing)

  • I think it would be nice if changes in the docker file triggered a container build on docker hub. Do we already do this?
  • There is lots of instruction on getting the graphics running (in bitbucket issues) within a container we can consolidate in the manual
  • I think we should pay for more significant docker resources
@gipert
Copy link
Member

gipert commented Aug 5, 2023

I should have enabled automated builds on DockerHub, triggered by pushes and PRs: https://hub.docker.com/repository/docker/g4edge/pyg4ometry/builds

PS: not sure about resources limits on DockerHub.

@stewartboogert
Copy link
Member Author

stewartboogert commented Aug 5, 2023

Right, but where should we put the docker file that includes the build of pyg4ometry and VNC/Xwindows etc. I could put a directory like ubuntu-pyg4ometry in the docker repo. Or I could put this in the main pyg4ometry repository

@gipert
Copy link
Member

gipert commented Aug 6, 2023

I would propose to name the base Docker images just ubuntu, manylinux2014_x86_64, ... and create a new "production ready" image (with pyg4ometry) named just `pyg4ometry". I would install any extra dependencies like VNC/Xwindows in the base images.

@gipert gipert transferred this issue from g4edge/pyg4ometry Aug 6, 2023
@gipert
Copy link
Member

gipert commented Aug 6, 2023

b356e61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants