Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nestjs-firebase] is @Global() really needed? #318

Closed
0ttik opened this issue Oct 13, 2020 · 1 comment
Closed

[nestjs-firebase] is @Global() really needed? #318

0ttik opened this issue Oct 13, 2020 · 1 comment
Labels
help wanted Extra attention is needed wontfix

Comments

@0ttik
Copy link

0ttik commented Oct 13, 2020

hello.

have u considered making nestjs-firebase module not @Global()? i think generally it's better for module which is distributed to be local because one can always make it global by wrapping it into another global module but the opposite cannot be done.

consider the situation where you would want to restrict firebase usage to certain modules.

@9renpoto 9renpoto added the Type: Question Further information is requested label Oct 14, 2020
@9renpoto 9renpoto added help wanted Extra attention is needed and removed Type: Question Further information is requested labels Nov 12, 2020
@stale
Copy link

stale bot commented Jan 14, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 14, 2021
@stale stale bot closed this as completed Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed wontfix
Projects
None yet
Development

No branches or pull requests

2 participants