Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove route demo #11

Open
RealWeeks opened this issue May 31, 2016 · 6 comments
Open

Remove route demo #11

RealWeeks opened this issue May 31, 2016 · 6 comments

Comments

@RealWeeks
Copy link
Member

Seems unnecessary.
@RealWeeks
Copy link
Member Author

removed in commit 14f5e3a

@gaand gaand reopened this May 31, 2016
@gaand
Copy link

gaand commented May 31, 2016

Please explain why this was in this lesson and why you removed it. Thanks!

@RealWeeks
Copy link
Member Author

@gaand No idea why it was in the lesson, so I removed it. Seemed out of scope.

@RealWeeks
Copy link
Member Author

On second thought, I think it's better removed. This is covered very in depth in routing-static

@gaand
Copy link

gaand commented Jun 5, 2016

Okay. I just want to make sure that before you remove something form a lesson, you've thought about why it might be there. For instance, does covering it briefly here support covering it in more depth later? I don't know, but it might be worth thinking through.

@jrhorn424
Copy link

I agree with @gaand. Please take a bit longer to explain your thoughts in PRs and issues. It helps me since I'm not in the room and not always a part of the conversations you have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jrhorn424 @gaand @RealWeeks