Feature/2385/config #2401
Merged
Feature/2385/config #2401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
denis-yuen
approved these changes
Apr 17, 2019
| gitlabRedirectPath: /auth/gitlab.com | ||
| gitlabScope: api | ||
|
|
||
| googleScope: profile email |
There was a problem hiding this comment.
Yes, that's how it is in dockstore.model.ts
| import io.swagger.annotations.ApiModel; | ||
| import org.apache.commons.beanutils.BeanUtils; | ||
|
|
||
| @ApiModel("Config") |
There was a problem hiding this comment.
Agreed, but I'm having a hard time thinking of anything better. Any ideas?
UIConfig? Configuration? UIConfiguration? Those aren't really any better, but I'm drawing a blank.
There was a problem hiding this comment.
I kept the name but added a description.
garyluu
approved these changes
Apr 23, 2019
agduncan94
approved these changes
Apr 23, 2019
#2385 Adds a new endpoint, /metadata/config to retrieve information to be used by the UI. As part of this, make githubClientID and githubClientSecret simple strings -- they were List<String>. The List was to support the transition from ui1 to ui2, but now that the UI will soon be retrieving the client id from the web service, it no longer makes sense.
Missed checking in yaml files
Add a description to Config
coverbeck
force-pushed
the
feature/2385/config
branch
from
c776cf5
to
39784cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose configuration information for consumption by the API.
In doing so, change githubClientId and githubClientSecret to be
String-- they wereList<String>for legacy reasons for the migration from ui1 to ui2.Because of that change I needed to update dockstoreTest.yml, which was specifying those values as arrays, and hence the secret archive, even though nothing secret in the secret archive changed.
The Google Tag Manager id is not in here; I will need to think about that one separately.