Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FData class #21

Closed
pablomm opened this issue Nov 21, 2018 · 2 comments
Closed

FData class #21

pablomm opened this issue Nov 21, 2018 · 2 comments
Labels
Projects

Comments

@pablomm
Copy link
Member

pablomm commented Nov 21, 2018

In the branch feature/fdata I created the class FData to unify the API of FDataBasis and FDataGrid. It is just a suggestion of a possible API. I would like to discuss which methods are more appropriated to be in the common class and the interface of the methods.

In particular the api of evaluate and the parameter keepdims.

https://github.com/GAA-UAM/fda/blob/859bb4055bd9a325fb1321ddb6b4d761013489ad/fda/fdata.py#L47-L50

@pablomm pablomm added this to In progress - Pablo Marcos in Kanban fda Nov 21, 2018
@vnmabus
Copy link
Member

vnmabus commented Nov 21, 2018

First, remove the constructor, as FData is an abstract class.
Second, I think the properties should be abstract.

I think I agree with the other proposed changes.

pablomm pushed a commit that referenced this issue Dec 18, 2018
@pablomm
Copy link
Member Author

pablomm commented Dec 18, 2018

Closed in #26.

@pablomm pablomm closed this as completed Dec 18, 2018
@pablomm pablomm moved this from In progress - Pablo Marcos to Done in Kanban fda Jan 6, 2019
DavidGarciaFer pushed a commit that referenced this issue Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Kanban fda
  
Done
Development

No branches or pull requests

2 participants