Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with peer dependencies found (axios version from axios-cache-adapter) #419

Closed
ben-barbier opened this issue Apr 19, 2022 · 4 comments
Assignees
Labels
wontfix This will not be worked on

Comments

@ben-barbier
Copy link

What version of pokenode-ts are you using?

1.13.0

What version of Node.js are you using?

16.13.0

What operating system are you using?

macOS

Describe the Bug

When we install the project, pnpm block the process due to this peer-dependency issue :

image

Expected Behavior

No peer-dependency issue 😄.

To Reproduce

Execute command pnpm i pokenode-ts.

@Gabb-c Gabb-c self-assigned this Apr 20, 2022
@Gabb-c
Copy link
Owner

Gabb-c commented Apr 20, 2022

Hey @ben-barbier, thanks for your input!
This unmet peer dependency shouldn't do any errors. But yes, it's not recommended to have unmet peer deps.

Seems like the axios-cache-adapter isn't maintained anymore.
Maybe axios-cache-interceptor is a great replacement.

@ben-barbier
Copy link
Author

Moving from axios-cache-adapter to axios-cache-interceptor seems like a good idea :-)

Is it a lot of work?

@stale
Copy link

stale bot commented Jun 22, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jun 22, 2022
@stale
Copy link

stale bot commented Jun 29, 2022

This issue has been automatically closed because it has not had recent activity. Thank you for your contributions.

@stale stale bot closed this as completed Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants