Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stopwatch.h problem since updating v1.10.0 #2434

Closed
fabianbuettner opened this issue Jul 12, 2022 · 3 comments
Closed

stopwatch.h problem since updating v1.10.0 #2434

fabianbuettner opened this issue Jul 12, 2022 · 3 comments

Comments

@fabianbuettner
Copy link

fabianbuettner commented Jul 12, 2022

Hi,

after updating the spdlog module in my project to v1.10.0 I noticed the following compilation error:
spdlog/include/spdlog/stopwatch.h:30:24: error: ‘chrono’ in namespace ‘std’ does not name a type 30 | using clock = std::chrono::steady_clock;

I can workaround that by including chrono before including stopwatch.h, but I am not sure if this is the expected behavior.

best regards,
Fabian

@gabime
Copy link
Owner

gabime commented Jul 12, 2022

Thanks for reporting. Indeed seems the include for chrono is missing in stopwatch.h

@fabianbuettner
Copy link
Author

No problem. do you want me to create a pull request for it?

@gabime
Copy link
Owner

gabime commented Jul 17, 2022

Sure. Please do.

@gabime gabime closed this as completed in f44fa31 Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants