Syslog dependency fails on windows builds

[mintyc]

Compiling examples on mingw
cd example
make --makefile=Makefile.mingw all

Fails due to an missing syslog sink on windows

Quick fix: Wrap function include/spdlog/details/spdlog_impl.h:88

#ifdef __linux__
// Create syslog logger
inline std::shared_ptr<spdlog::logger> spdlog::syslog_logger(const std::string& logger_name)
{
    return create<spdlog::sinks::syslog_sink>(logger_name);
}
#endif

Or create dummy windows impl in syslog_sink.h - skip syslog.h include and make log function empty on windows?

[mintyc]

I'm new to git, but I've sent a git pull request with this change (and another to allow build/run for bench)

Dummy implementation - does nothing
Remove the #ifdef linux elsewhere and add a dummy impl in syslog_sink.h

git diff 'patch'

diff --git a/include/spdlog/sinks/syslog_sink.h b/include/spdlog/sinks/syslog_sink.h
index 1d7c28d..d5a20ec 100644
--- a/include/spdlog/sinks/syslog_sink.h
+++ b/include/spdlog/sinks/syslog_sink.h
@@ -24,10 +24,20 @@

 #pragma once

-#ifdef __linux__
-
 #include <string>
+#ifdef __linux__
 #include <syslog.h>
+#else
+   inline void syslog(int /*prio*/, const char */*fmt*/, ...) {}   // TODO Windows Syslog not supported
+   #define LOG_EMERG       0       /* system is unusable */
+   #define LOG_ALERT       1       /* action must be taken immediately */
+   #define LOG_CRIT        2       /* critical conditions */
+   #define LOG_ERR         3       /* error conditions */
+   #define LOG_WARNING     4       /* warning conditions */
+   #define LOG_NOTICE      5       /* normal but significant condition */
+   #define LOG_INFO        6       /* informational */
+   #define LOG_DEBUG       7       /* debug-level messages */
+#endif
 #include "./sink.h"
 #include "../common.h"
 #include "../details/log_msg.h"
@@ -84,5 +94,3 @@ namespace spdlog
     };
   }
 }
-
-#endif
diff --git a/include/spdlog/spdlog.h b/include/spdlog/spdlog.h
index 42bff20..636dbeb 100644
--- a/include/spdlog/spdlog.h
+++ b/include/spdlog/spdlog.h
@@ -69,9 +69,7 @@ std::shared_ptr<logger> stderr_logger_st(const std::string& logger_name);


 // Create a syslog logger
-#ifdef __linux__
  std::shared_ptr<logger> syslog_logger(const std::string& logger_name);
-#endif


 //

[gabime]

Fix in commit 1008f56