20 vault arg #22
Merged
20 vault arg #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 25, 2017 15:00
Empty argument was searching for vault in the package directory, rather than at the `pkg_root` path. To fix, I temporarily change the `secret.vault` option in the test
putting the `find_vault` first ensures that even if the vault argument is empty (default NULL), then there will still be a path to check against.
gaborcsardi
reviewed
Jul 25, 2017
tests/testthat/test-6-issues.R
Outdated
| ) | ||
| } | ||
|
|
||
| old.o <- options(secret.vault = getOption("secret.vault", pkg_root)) |
There was a problem hiding this comment.
Please use withr::with_options() there instead of manually managing the options.
There was a problem hiding this comment.
Absolutely. Didn't realize this package existed. Was looking for something like it.
|
Thanks, looks great! Could you please change the test that I commented on? Thanks! |
|
Looks good, thanks much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put the
find_vaultbefore theis_valid_dircheck, so that it actuall has something to check against.Added a test to the issues testfile.