Support unit test sources #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Issues reported for test sources are ignored since they have UTS qualifier. They are reported to the global comment but have no links and are just plain text. Only link to the rule is generated.
Detailed: this happens because no file is found for issue and null is passed further to generate the report.
General
Test sources also can have issues like for rule squid:S3415: Assertion arguments should be passed in the correct order. Those who use rules like these will experience issues with plugin.
Solution
Use UTS qualifier along with FIL qualifier.
Unit tests are added to check whether issues with both qualifiers make it through. If SonarFacade will drop support of UTS then tests will report NullPointerExceptions since there will be no file assigned to the issue.