Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+[NSURL gh_queryStringToDictionary:] crashes when passed an incorrectly encoded string #6

Open
bmelts opened this issue Feb 22, 2013 · 0 comments

Comments

@bmelts
Copy link

bmelts commented Feb 22, 2013

+[NSURL gh_decode] assumes UTF-8 urlencoding - if used with a differently encoded URL (e.g. Latin-1) it crashes hard.

I was unsure about the right course of action here, though - raise an exception, ignore the broken entry entirely, or (if it's the value that's busted) use an NSNull instead?

(Also, does gh_decode do anything that -[NSString stringByReplacingPercentEscapesUsingEncoding:] doesn't?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant