Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code correction #3

Closed
camilord opened this issue Jul 13, 2021 · 1 comment
Closed

code correction #3

camilord opened this issue Jul 13, 2021 · 1 comment

Comments

@camilord
Copy link

hello, i am currently using your jquery ripple effect ...

i found an error in your code:

image

can you please correct this? thanks.

change from:

$(document).on("pointerup mouseleave dragleave touchmove touchend touchcancel", ".md-ripples", function() {
    const ripples = $(this).find(".ripple");
    if (ripples.lenght != 0) {
        ripples.animate({opacity: 0}, 600, function() {
            ripples.remove();
        });
    }
});

change to:

$(document).on("pointerup mouseleave dragleave touchmove touchend touchcancel", ".md-ripples", function() {
    const ripples = $(this).find(".ripple");
    if (ripples.length != 0) {
        ripples.animate({opacity: 0}, 600, function() {
            ripples.remove();
        });
    }
});
@gabrielfins
Copy link
Owner

hey, thanks for pointing that out. it should be fixed by now. the funny thing is that it seemed to be working the intended way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants