Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be able to accept special chars #1

Closed
gabrielfurini opened this issue Dec 27, 2018 · 4 comments
Closed

Be able to accept special chars #1

gabrielfurini opened this issue Dec 27, 2018 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@gabrielfurini
Copy link
Owner

For now the library only has ordinal letters and digits into its dictionary. Make it able to handle special characters too

@gabrielfurini gabrielfurini added the enhancement New feature or request label Dec 27, 2018
@gabrielfurini gabrielfurini self-assigned this Dec 27, 2018
@vinyvicente
Copy link

Have sure?

Maybe just to translate "áááááééééíííí" before encode.

Has morse code to special chars?

@evansantos
Copy link

I don't know if I should open a new issue, but enter wouldn't add a slash or something like because when you get a text instead of a quote it's get all mess up

https://9o8x7rwor4.codesandbox.io/

@gabrielfurini
Copy link
Owner Author

@vinyvicente, I expressed myself erroneously. I was referring to special chars for punctuation not accentuation. These ones definitely should be represented and they gonna be there soon, in the next version probably.

@gabrielfurini
Copy link
Owner Author

gabrielfurini commented Dec 29, 2018

@evansantos you're definitely right about a new line representation. Gonna research the right way of doing it. BTW I've just opened a new issue (#2). Thanks for reporting it 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants