Implemented AndroidDateTimeTextProvider #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technically I don't see any problems of setting this to 9, but I don't think that anybody will test it on such devices. minSdkVersion must be >= 9 to support Standalone text styles.
|
Travis build failed because there is no connected devices for |
|
Hey, sorry I somehow missed this. I'll take a look at it this week. |
|
I think it would be better if you published this as a separate library. The advantage would be that user's can choose to use one or the other and that both libraries are focused on achieving one goal. Thanks for the pr though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented custom
DateTimeTextProviderto use Android-specific features inSimpleDateFormatto improve Narrow and Standalone text styles of months and days of week.Uses ThreeTen/threetenbp#69
Fixes ThreeTen/threetenbp#55 for Android users.