Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not call exit on Android or iOS #23

Open
dnfield opened this issue Feb 5, 2024 · 4 comments
Open

Do not call exit on Android or iOS #23

dnfield opened this issue Feb 5, 2024 · 4 comments

Comments

@dnfield
Copy link

dnfield commented Feb 5, 2024

Calling exit is not safe in Flutter applications. It results in unpredictable shutdown/destruction of objects and crashes.

See e.g. flutter/flutter#142835

Please consider updating your plugin to not call exit.

@kekko7072
Copy link

@dnfield did you pull request a solution?

@Trung15010802
Copy link

any update?

@dnfield
Copy link
Author

dnfield commented Feb 23, 2024

I'm not sure I fully understand the use case for this plugin or how to achieve it's actual goal. Whatever it's goal is, calling exit isn't safe and will cause crashes sometimes.

@bulwinkel
Copy link

@dnfield My specific use case is with shorebird.dev to allow users to apply a patch. e.g. we detect a new patch is available, show an in app notification which if the user taps, it causes the app to restart applying the patch.

Given that scenario, do you know if there there a safe mechanism available to force the app's process to close? Happy to implement and open a PR.

Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants