Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS2017 - definition of dllimport function not allowed errors #24

Open
adam-hartshorne opened this issue Feb 25, 2018 · 4 comments
Open

Comments

@adam-hartshorne
Copy link

adam-hartshorne commented Feb 25, 2018

When building the library and various projects, I receive a number of #C2491 errors e.g. error C2491: 'ApproxMVBB::approximateMVBBGridSearch': definition of dllimport function not allowed

I believe it is this problem which is specific to Visual Studio compiler,

https://msdn.microsoft.com/en-us/library/62688esh.aspx

https://docs.microsoft.com/en-us/cpp/cpp/using-dllimport-and-dllexport-in-cpp-classes

@gabyx
Copy link
Owner

gabyx commented Feb 25, 2018

could you send me the output log :) thanks. then i can fix it

@gabyx
Copy link
Owner

gabyx commented Feb 25, 2018

or even better send me a PR :) eith the fix. because I have no windows here :)

@adam-hartshorne
Copy link
Author

Find attached the output log. I am away this week, so I am not going to have a chance to properly look at a potential fix myself for the next few days.

AproxMVBB_vs2017_build_log.txt

@gabyx
Copy link
Owner

gabyx commented Sep 19, 2018

Could you test on the current master branch with VS 17 if the problem persists?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants