Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent OnMessage event from firing when message is empty #5

Open
gacardinal opened this issue Jan 21, 2019 · 2 comments
Open

Prevent OnMessage event from firing when message is empty #5

gacardinal opened this issue Jan 21, 2019 · 2 comments
Assignees

Comments

@gacardinal
Copy link
Owner

Many browsers / client side implementations of the WebSocket protocol send a frame with a null byte just before disconnecting, in that case, the user of the library should not receive an OnMessage event.

@gacardinal
Copy link
Owner Author

Also, the OnMessage event should not be invoked if the message is comprised only of a unicode control character, because it seems like some browsers like to not follow the WebSocket specification and send things like an ETX unicode character in a data frame when the socket closes

@gacardinal gacardinal self-assigned this Feb 27, 2019
@shelbyyyyy
Copy link

@Gaboik Is this still relevant? If not, please delete/close the issue. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants