Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should epoxy_transform_html() collapse to single string? #96

Closed
gadenbuie opened this issue Jun 8, 2023 · 1 comment
Closed

Should epoxy_transform_html() collapse to single string? #96

gadenbuie opened this issue Jun 8, 2023 · 1 comment

Comments

@gadenbuie
Copy link
Owner

I remember having reasons why I switched away from this – likely due to an interaction with the inline transformer – but this doesn't feel right:

library(epoxy)
epoxy_html("<ul>{{li letters[1:3]}}<ul>")
<ul><li>a</li><ul>
<ul><li>b</li><ul>
<ul><li>c</li><ul>
@gadenbuie
Copy link
Owner Author

I switched here: 126d27c

I'm fairly certain I was working on getting the right semantics for the html > inline transformers.

I think it'll be a lot better in most cases to have the inline html transformation return a single character string, but I'll make it optional with a collapse argument.

I also realized that it's important that the inline transformers for epoxy_transform_inline(), e.g. for .strong or .emph, must also return a vector of html characters and this is likely why I thought I needed to change the original behavior of epoxy_html().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant