Only match stateless functional components where the first letter is a capital #40
Conversation
standard in React. A lot of false positives will occur from accepting lower case functions. This closes gadicc#30.
|
Awesome, thanks for this! Yes, we should have done this straight from the beginning. Thanks also for noticing the duplicated code. Initially the accelerator was part of the babel-compiler-hot package, which is why it's all in a single file and a bit weird. In theory moving forward we could probably export some things from there for use in the babel-compiler-hot. Some of the funcs are slightly different in each case though. |
|
I was somewhat lucky to find the duplicated code. It's definitely a bit confusing and error prone. I think factoring out at least the RegEx and source transformation would be a good idea. |
|
Yeah I'm going to try clean it up over the next week, now that it's possible (originally there was no way to share code between the files). |
This is the standard in React.
A lot of false positives will occur from accepting lower case
functions.
This closes #30.