Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Insights and SEC Filings Validation Errors #665

Merged
merged 4 commits into from
Sep 6, 2023
Merged

Fixes Insights and SEC Filings Validation Errors #665

merged 4 commits into from
Sep 6, 2023

Conversation

z3nful
Copy link
Contributor

@z3nful z3nful commented Sep 5, 2023

Partially Closes #663 , and closes #664.

Changes

  • stopLoss under insights is not always present in response, changed to optional
  • sectorInfo under insights is not always present in response, changed to optional
  • Added missing Filing forms for some non-US companies

Type

  • New Module
  • Other New Feature
  • Validation Fix
  • Other Bugfix
  • Docs
  • Chore/other

Comments/notes

@z3nful z3nful closed this Sep 5, 2023
@z3nful z3nful reopened this Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (01faf98) 95.68% compared to head (37ea207) 95.68%.
Report is 1 commits behind head on devel.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel     #665   +/-   ##
=======================================
  Coverage   95.68%   95.68%           
=======================================
  Files          24       24           
  Lines         625      625           
  Branches      211      211           
=======================================
  Hits          598      598           
  Misses         27       27           
Files Changed Coverage Δ
src/modules/insights.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@z3nful z3nful changed the title Fixes Insights Validation Errors Fixes Insights and SEC Filings Validation Errors Sep 6, 2023
@gadicc
Copy link
Owner

gadicc commented Sep 6, 2023

Ooh, fantastic! Many thanks, @z3nful, this is a very welcome contribution. Thanks so much 🙏

@gadicc gadicc merged commit 23f2789 into gadicc:devel Sep 6, 2023
3 checks passed
@gadicc
Copy link
Owner

gadicc commented Sep 6, 2023

This will be in the next release, and there'll be an automatic message here when that happens.

gadicc pushed a commit that referenced this pull request Sep 6, 2023
## [2.4.7](v2.4.6...v2.4.7) (2023-09-06)

### Bug Fixes

* **insights:** Insights and SEC Filings validation errors ([#665](#665)) ([23f2789](23f2789)), closes [#663](#663) [#664](#664)
* **insights:** missing/optional fields/enums, tests (fixes [#663](#663)) ([3c02753](3c02753))
* **quoteSummary:** add Grade "ConvictionBuy"; tests foR ARMK ([#664](#664)) ([c0efc07](c0efc07))
@gadicc
Copy link
Owner

gadicc commented Sep 6, 2023

🎉 This PR is included in version 2.4.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gadicc gadicc added the released label Sep 6, 2023
gadicc pushed a commit that referenced this pull request Sep 15, 2023
## [2.4.7](v2.4.6...v2.4.7) (2023-09-06)

### Bug Fixes

* **insights:** Insights and SEC Filings validation errors ([#665](#665)) ([23f2789](23f2789)), closes [#663](#663) [#664](#664)
* **insights:** missing/optional fields/enums, tests (fixes [#663](#663)) ([3c02753](3c02753))
* **quoteSummary:** add Grade "ConvictionBuy"; tests foR ARMK ([#664](#664)) ([c0efc07](c0efc07))
gadicc pushed a commit that referenced this pull request Sep 18, 2023
## [2.4.7](v2.4.6...v2.4.7) (2023-09-06)

### Bug Fixes

* **insights:** Insights and SEC Filings validation errors ([#665](#665)) ([23f2789](23f2789)), closes [#663](#663) [#664](#664)
* **insights:** missing/optional fields/enums, tests (fixes [#663](#663)) ([3c02753](3c02753))
* **quoteSummary:** add Grade "ConvictionBuy"; tests foR ARMK ([#664](#664)) ([c0efc07](c0efc07))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed validation: #/definitions/QuoteSummaryResult Failed validation: #/definitions/InsightsResult
2 participants