Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module): Add new fundamentals time series module #748

Merged

Conversation

Shadaeiou
Copy link
Contributor

@Shadaeiou Shadaeiou commented Mar 9, 2024

Closes #745

Changes

  • Added module
  • Added tests
  • Added docs
  • Updated schema
  • Updated common

Type

  • [ x] New Module
  • Other New Feature
  • Validation Fix
  • Other Bugfix
  • Docs
  • Chore/other

Comments/notes

Copy link

codecov bot commented Mar 9, 2024

Codecov Report

Attention: Patch coverage is 97.77778% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 93.41%. Comparing base (7a1d03b) to head (9842b94).
Report is 2 commits behind head on devel.

Files Patch % Lines
src/modules/fundamentalsTimeSeries.ts 97.77% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #748      +/-   ##
==========================================
+ Coverage   93.12%   93.41%   +0.29%     
==========================================
  Files          26       27       +1     
  Lines         669      714      +45     
  Branches      226      240      +14     
==========================================
+ Hits          623      667      +44     
- Misses         46       47       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gadicc gadicc merged commit 1681d33 into gadicc:devel Mar 9, 2024
3 checks passed
@gadicc
Copy link
Owner

gadicc commented Mar 9, 2024

Wow 😮 You, Sir, are a legend! 🙇

  1. It's your first contribution to the project
  2. It's an entirely new module
  3. It's a perfect submission in terms of style, docs, tests, etc.

Thanks so much! This is great! And so well timed. 🙏 🙏

@gadicc
Copy link
Owner

gadicc commented Mar 9, 2024

This will be in the next release, and there'll be an automated message here when that happens.

Thanks once again. How was your first contribution? Is there anything we can make clearer anywhere?

gadicc pushed a commit that referenced this pull request Mar 9, 2024
# [2.10.0](v2.9.2...v2.10.0) (2024-03-09)

### Features

* **module:** Add new fundamentals time series module ([#748](#748)) ([1681d33](1681d33))
@gadicc
Copy link
Owner

gadicc commented Mar 9, 2024

🎉 This PR is included in version 2.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Shadaeiou
Copy link
Contributor Author

This will be in the next release, and there'll be an automated message here when that happens.

Thanks once again. How was your first contribution? Is there anything we can make clearer anywhere?

Hey, no problems! I've been using this library for a long time so it was nice to dig in and see how it works! I figured what I've written is probably a good start and can be iterated on, I just really wanted the data and was sad when I saw that they must have changed the API!

The actual code was easy to write because I had so many good examples to reference. As for the actual contributing documentation, well considering that I've used little very little Typescript and very little yarn, it was actually very easy! I missed formatting and coverage at first and that was definitely user error, which was eventually caught by CI and I was able to easily correct.

Thanks for all your hard work and kudos for such a well written library! I'll definitely keep my eyes open for more ways I can contribute!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New module request: timeseries
2 participants