Skip to content
This repository has been archived by the owner on Apr 9, 2020. It is now read-only.

array-find issue #73

Closed
morlay opened this issue Jan 7, 2016 · 2 comments
Closed

array-find issue #73

morlay opened this issue Jan 7, 2016 · 2 comments

Comments

@morlay
Copy link

morlay commented Jan 7, 2016

Since babel@6.4, they will not include polyfills, but other shims like collections will be used in process scope ( babel-polyfill will overwrite them before )

montagejs/collections#139

It will broken matchesPatterns, because of

!!-1 // return true

Just notice it, if someone use webpack with other packages, the global shim will make babel-plugin-react-transform broken

@gaearon
Copy link
Owner

gaearon commented Mar 5, 2016

Thanks for reporting. This is a pretty ugly situation because no build tool should ever put polyfills (especially broken ones!) in the global scope. However I agree it’s best that we work around this.

@gaearon gaearon closed this as completed in 6bb8c60 Mar 5, 2016
@gaearon
Copy link
Owner

gaearon commented Mar 5, 2016

This is fixed in 2.0.2.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants