fix: rethrow an error is hot comparison is not open

gaearon · Feb 20, 2019 · 8befa5a · 8befa5a
1 parent 8240111
commit 8befa5a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/src/AppContainer.dev.js b/src/AppContainer.dev.js
@@ -47,6 +47,7 @@ class AppContainer extends React.Component {
 
       // trigger update to kick error
       this.setState({})
+      throw error
       return
     }
     const { errorReporter = configuration.errorReporter } = this.props

diff --git a/src/reconciler/proxyAdapter.js b/src/reconciler/proxyAdapter.js
@@ -2,6 +2,7 @@ import React from 'react'
 import {
   enterHotUpdate,
   get as getGeneration,
+  hotComparisonOpen,
   setComparisonHooks,
 } from '../global/generation'
 import { getProxyByType, setStandInOptions } from './proxies'
@@ -115,6 +116,9 @@ export function retryHotLoaderError() {
 setComparisonHooks(
   () => ({}),
   component => {
+    if (!hotComparisonOpen()) {
+      return
+    }
     const { prototype } = component
     if (!prototype[OLD_RENDER]) {
       const renderDescriptior = Object.getOwnPropertyDescriptor(