Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hook update #1298

Merged
merged 2 commits into from Jul 10, 2019
Merged

Fix hook update #1298

merged 2 commits into from Jul 10, 2019

Conversation

theKashey
Copy link
Collaborator

Related: #1294

The problem

As a final action hotComponentCompare/compareComponents is doing updateProxyById, EVEN if they are the same, thus moving getHotGeneration forward and invalidating all hooks, causing infinite update loop.

Fix

馃し鈥嶁檪锔廌on't do it - if a proxy is not updated - don't change counter.

@codecov-io
Copy link

codecov-io commented Jul 10, 2019

Codecov Report

Merging #1298 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1298      +/-   ##
==========================================
+ Coverage   79.01%   79.02%   +0.01%     
==========================================
  Files          39       39              
  Lines        1625     1626       +1     
  Branches      416      417       +1     
==========================================
+ Hits         1284     1285       +1     
  Misses        277      277              
  Partials       64       64
Impacted Files Coverage 螖
src/reconciler/proxies.js 97.77% <100%> (酶) 猬嗭笍
src/proxy/createClassProxy.js 98.77% <100%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 9c87cbc...afa8ed4. Read the comment docs.

@theKashey theKashey merged commit c703d2e into master Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants