Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not compatible with loadable-components? #1361

Open
harrisonlo opened this issue Oct 15, 2019 · 1 comment
Open

Not compatible with loadable-components? #1361

harrisonlo opened this issue Oct 15, 2019 · 1 comment

Comments

@harrisonlo
Copy link

harrisonlo commented Oct 15, 2019 •
edited

As reported in gregberge/loadable-components#243 react-hot-loader doesn't seem to be "compatible" with loadable-components, there needs to be multiple hot() where code-splitting is used.

Is this known and intended? If so, please update the README and remove loadable-components as a "compatible" lib. Else, please fix this issue :) A reproducible demo is in the linked issue above.

Thank you!
@theKashey
Copy link
Collaborator

Loadable-components are not compatible with RHL, that's true, as long as they are not re-importing updated module.

Probably it's better to reevaluate this - the current version of React Universal Component might be also not compatible with RHL.

#1339, if ever got implemented, should solve it.

@justin808 justin808 mentioned this issue Mar 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@theKashey @harrisonlo