Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot-Reloading@3 not working #432

Closed
sathishsoundharajan opened this issue Nov 29, 2016 · 13 comments
Closed

Hot-Reloading@3 not working #432

sathishsoundharajan opened this issue Nov 29, 2016 · 13 comments

Comments

@sathishsoundharajan
Copy link
Contributor

If you are reporting a bug or having an issue setting up React Hot Loader, please fill in below. For feature requests, feel free to remove this template entirely.

Description

What you are reporting: Hot Reloading not working

Expected behavior

What you think should happen: Hot Reloading should work

Actual behavior

What actually happens: Hot Reloading not working, but it was working previously on another system.

Environment

React Hot Loader version: 3.0.0-beta.6

Run these commands in the project folder and fill in their results:

  1. node -v: 6.0.0
  2. npm -v: 3.8.6

Then, specify:

  1. Operating system: Windows 8.1
  2. Browser and version: Chrome 55

Reproducible Demo

Repro Repo
https://github.com/bboysathish/repro-hot-loading

@sathishsoundharajan
Copy link
Contributor Author

@calesce Can you please take a look into it, if you have time. It should be some configuration issue as i am not getting error while running i am not able to figure it out,

Note: This was working on one another system.

@alex-shamshurin
Copy link

This is something wrong with webpack configuration there. new webpack.HotModuleReplacementPlugin() is missing, besides, I do not see that HMR is enabled in console.

@sathishsoundharajan
Copy link
Contributor Author

@calesce
Copy link
Collaborator

calesce commented Nov 30, 2016

@bboysathish I haven't had time to look closely, but for webpack-hot-middleware you'll need OccurenceOrderPlugin and NoErrorsPlugin. Also make sure you're using transform-es2015-classes, there's a bug with built-in classes (#313).

@sathishsoundharajan
Copy link
Contributor Author

@calesce Now that i have added those 2 plugins, still i am not able to see HMR in console

https://github.com/bboysathish/repro-hot-loading/blob/master/configuration/webpack/dev.js#L73-L74

@alex-shamshurin
Copy link

Me too... Something is totally wrong.

@sathishsoundharajan
Copy link
Contributor Author

@alex-shamshurin Have you tried forking my repo and run from your local ?

@alex-shamshurin
Copy link

alex-shamshurin commented Dec 1, 2016

Yes, I've done it just before write here. The error is not related with RHL, but probably with webpack itself. Anyway it must print "[HMR] connected" even without RHL at all. But I do not see it.

@calesce
Copy link
Collaborator

calesce commented Dec 1, 2016

If it's not an issue specifically with React Hot Loader (as it looks like here), please go to StackOverflow, Webpack's gitter, or Reactiflux.

@calesce calesce closed this as completed Dec 1, 2016
@sathishsoundharajan
Copy link
Contributor Author

@calesce I don't think it is error on webpack. How can i narrow down it is webpack or RHL ? i can open a same issue in webpack repo also.

@calesce
Copy link
Collaborator

calesce commented Dec 1, 2016

If you're not even seeing HMR messages in the console, then it's likely not RHL, because it needs HMR to be able to work. I'd recommend looking at a working example, and making your project match that piece-by-piece until it works.

@sathishsoundharajan
Copy link
Contributor Author

@alex-shamshurin & @calesce Found the issue, removing reload=true from webpack-hot-client makes the RHL working https://github.com/bboysathish/repro-hot-loading/commit/0fb699e9e62be5cd69fa5ce1c93146c6982acdcc

@alex-shamshurin
Copy link

alex-shamshurin commented Dec 1, 2016

@bboysathish I have tried already but it doesn't help. Anyway, you should first ensure that you see "[HMR] connected"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants