-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken/outdated 'this' in class properties #435
Comments
Thanks for the issue. Can you share your Babel config? |
Certainly, https://gist.github.com/awv-inf/257464c57fd19b656858c6ffd5a87c91 The babel config is in the first blob. It applies to env.dev only, where react-hot-loader is inlined. |
You may need to add |
This worked indeed, thanks! With the downside of course that now we have transpiled classes. Is this a browser bug or will it get fixed in RHL? |
Fixed in RHL. It seems most likely that the issue is at the react-proxy layer. Its tests are run against both transpiled and built-in classes, so I'm not sure what's causing it to fail. |
Going to close this out because you got it working and the underlying issue is #313. |
Hot loader currently seems to confuse 'this' in class property methods. It points at an older class instance without refs or locals.
Environment
React Hot Loader version: 3.0.0-beta.6
Run these commands in the project folder and fill in their results:
node -v
: v7.2.0npm -v
: 3.10.5Then, specify:
The text was updated successfully, but these errors were encountered: