Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard reloading instead of hot loading #58

Closed
natew opened this issue Jan 11, 2015 · 6 comments
Closed

Hard reloading instead of hot loading #58

natew opened this issue Jan 11, 2015 · 6 comments

Comments

@natew
Copy link
Contributor

natew commented Jan 11, 2015

Not sure if this is related to #55 because I did recently split out my app into separate modules and so it's symlinking pieces of the app. I've also made quite a lot of changes though lately so not sure where to start here.

Here's a screen of my setup, the dirs with the extra icon are symlinked:

screen shot 2015-01-11 at 2 07 55 pm

I'm running my server in a separate repo, which symlinks in it's dependencies into server_modules in the app folder.

What I see happening in the app now is the "Reloading..." comes up just fine. Before it would even show the "reloaded" message but nothing would change. But recently it started refreshing the browser instead, no matter what I change. So I see Reloading... then browser refreshes.

I had tried the NewWatching plugin, but reverted that. Other than that not sure whats new. Using 1.0.7 of react-hot-loader.

@gaearon
Copy link
Owner

gaearon commented Jan 11, 2015

Does this happen with 1.0.6?

@gaearon
Copy link
Owner

gaearon commented Jan 11, 2015

By the way, to avoid refreshing completely (even when you have syntax errors), use hot/only-dev-server and NoErrorsPlugin. This setup is shown in react-hot-boilerplate:

https://github.com/gaearon/react-hot-boilerplate/blob/master/webpack.config.js

But let's figure out the main issue first..

@gaearon
Copy link
Owner

gaearon commented Jan 11, 2015

If you don't feel comfortable sharing the source we can arrange a 15min TeamViewer session to figure this out once and for all. Ping me at email or on Skype (dan.ex) if you'd like to do that.

@natew
Copy link
Contributor Author

natew commented Jan 12, 2015

Would love to do a screen share because I'd bet you have some good insight into how I'm structuring things as well. I'll add you on Skype.

@gaearon
Copy link
Owner

gaearon commented Jan 12, 2015

btw you can give it another go with 1.1.0, node_modules issues should be fixed

@gaearon
Copy link
Owner

gaearon commented Jan 13, 2015

Fixed with 1.1.1

@gaearon gaearon closed this as completed Jan 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants